Fix compilation if std::format_string is not known #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may happen since `std::format_string` was exposed in later [P2508R1](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2508r1.html)
R2RT
force-pushed
the
fix/std-format-string-not-defined
branch
from
736192f
to
609b95f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
std::format_stringwas retroactively exposed in C++20 by P2508R1Some STL implementations may not have it implemented (e.g. one shipped with MSVC cl.exe 19.34.31935).
Solution:
__cpp_lib_format >= 202207L, usestd::string_viewwhen too old.__cpp_lib_format >= 202207Lto enableBOOST_UT_HAS_FORMAT