Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix win_compat_test.cpp when building with mingw #602

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Fix win_compat_test.cpp when building with mingw #602

merged 1 commit into from
Dec 19, 2023

Conversation

helmesjo
Copy link
Contributor

Problem:

  • Preprocessor error out since mingw-gcc doesn't define min or max in its Windows.h header.

Solution:

  • Don't check for min or max defines when building with mingw.

Reviewers:
@kris-jusiak

@helmesjo
mingw-gcc doesn't not define min/max in its <Windows.h>, so the prepr…
ffeee51 
…ocessor check in 'win_compat_test.cpp' needs to be excluded in this case.
@helmesjo
Copy link
Contributor Author

@kris-jusiak No need for a new release just for this, but I figured I might as well fix it straight away.

@krzysztof-jusiak krzysztof-jusiak merged commit cb4800e into boost-ext:master Dec 19, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helmesjo @krzysztof-jusiak