비디오 업로드 예외처리 #164
Merged
비디오 업로드 예외처리 #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msjang4
previously approved these changes
Nov 30, 2023
server/src/video/video.service.ts
Outdated
| @@ -150,10 +154,20 @@ export class VideoService { | |||
| } | |||
|
|
|||
| async uploadVideo(videoDto: VideoDto, uuid: string, videoId: string) { | |||
| if (!Types.ObjectId.isValid(videoId)) throw new VideoNotFoundException(); | |||
There was a problem hiding this comment.
비디오 업로드 시 비디오를 찾을 수 없는 오류는 조금 어색해보여요
id가 잘못된거니까 BadRequestFormat이 좋아보이는데 어떠신가요?
Comment on lines
+69
to
+72
| /** | ||
| * 회원가입 시 프로필 이미지를 PUT하는 url 발급 | ||
| */ | ||
| @Get('signup/presigned-url/profile') |
There was a problem hiding this comment.
이렇게 프로필이미지 put presigned Url 발급을 나눈게 굉장히 좋은 거 같아요!
프로필 변경시 발급에서는 본인 Id만 발급가능하도록 할 수 있고, 회원가입시 발급에서는 DB에 없는 Id만 발급가능하게 해서 예외처리 할 수 있으니까요
msjang4
approved these changes
Dec 1, 2023
| [ErrorCode.ProfileUploadRequired]: '프로필 이미지를 먼저 업로드 해야합니다.', | ||
| [ErrorCode.ThumbnailUploadRequired]: '썸네일을 먼저 업로드 해야합니다.', | ||
| [ErrorCode.VideoUploadRequired]: '비디오를 먼저 업로드 해야합니다.', | ||
| [ErrorCode.BadRequestFormat]: '요청 형식이 잘못됨', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved: #163
작업 내용