Clova GreenEye API 요청 #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msjang4
previously approved these changes
Dec 10, 2023
Comment on lines
+22
to
+23
| // eslint-disable-next-line no-await-in-loop | ||
| const result = await greenEye(file, file, imageData, greenEyeSecret); |
There was a problem hiding this comment.
for문에서는 await를 하지 않는게 권장이군여
promise 패턴과 재귀를 활용해보면 좋을 수도..? 제가 한번 고민해볼게요
| } | ||
| } | ||
|
|
||
| const createScreanshots = async (videoUrl) => { |
There was a problem hiding this comment.
함수 내에서 await를 안하면 async를 안붙여도 되는데 이 함수처럼 promise를 리턴하는 경우 명시성을 위해 일부러 붙여주기도 하더라고요! 그런 점을 고려하신건지 궁금해요~
There was a problem hiding this comment.
흠 아마 깊게 고려하진 않았던 것 같아요
msjang4
previously approved these changes
Dec 11, 2023
| @@ -21,7 +21,7 @@ export class AuthGuard implements CanActivate { | |||
| } | |||
| try { | |||
| const payload = await this.jwtService.verifyAsync(token); | |||
| request.user = payload; | |||
| request.user = { ...payload }; | |||
There was a problem hiding this comment.
앗 이건 token 추가하려고 이렇게 했었어요 ㅎㅎ
msjang4
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved: #237
작업 내용
전달 사항