노드 정렬 알고리즘(LayoutManager)구현, 리팩토링 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodes 프로퍼티가 나타내는 의미가 자식 노드인데, 자식 노드는 무조건 RectangleNode이기 때문에 RectangleNode로 변경함
jaehan4707
reviewed
Nov 18, 2023
| val scale = context.resources.displayMetrics.density | ||
| return (pxVal / scale).toInt() | ||
| return pxVal / scale |
jaehan4707
approved these changes
Nov 18, 2023
| @@ -3,17 +3,17 @@ package boostcamp.and07.mindsync.data.model | |||
| sealed class Node( | |||
| open val path: NodePath, | |||
| open val description: String, | |||
| open val nodes: List<Node>, | |||
| open val nodes: List<RectangleNode>, | |||
There was a problem hiding this comment.
자식들은 무조건 RectangleNode 일수밖에 없어서 이렇게 하신것도 좋은거 같아요
hegleB
reviewed
Nov 18, 2023
Comment on lines
3
to
+6
| sealed class Node( | ||
| open val path: NodePath, | ||
| open val description: String, | ||
| open val nodes: List<Node>, | ||
| open val nodes: List<RectangleNode>, |
There was a problem hiding this comment.
Node를 RectangleNode로 변경하신 부분이 매우 좋은 거 같습니다!!
hegleB
reviewed
Nov 18, 2023
Comment on lines
10
to
12
| private val verticalSpacing = Dp(50f) | ||
|
|
||
| fun arrangement(node: Node): Node { |
There was a problem hiding this comment.
arrangement 함수를 동사로 변경하면 좋을 거 같아요!!
There was a problem hiding this comment.
앗 맞네요 ㅎㅎ arrangeNode로 수정하겠습니다~!!
hegleB
reviewed
Nov 18, 2023
Comment on lines
67
to
69
| } | ||
|
|
||
| } |
hegleB
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업한 내용
Head 의 노드 정보가 주어졌을 때, Head를 기준으로 나머지의 위치를 재정렬 하는 코드 작성
Before : x, y 좌표를 직접 정해주지 않으면 자유분방하게 배치됨
After : arrangement 함수만 호출해주면 자동으로 정렬됨
리팩토링