마인드맵 텍스트 크기 자동화 #66
Merged
마인드맵 텍스트 크기 자동화 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
더블 클릭 시 텍스트 박스 그리기, 빈 화면 단일 클릭 시 텍스트 박스 지우기
더블 클릭 시 해당 지점에 노드가 있다면 다이얼로그를 출력
NodeClickListener color 추가, 다이얼로그 배경색 노드 배경색과 일치화
너비와 높이를 모두 반영해야하는데, 초기의 너비만 반영함. 따라서 높이가 반영이 안되는 문제가 생김.
# Conflicts: # AOS/app/src/main/java/boostcamp/and07/mindsync/ui/view/NodeView.kt
|
LGTM |
hegleB
approved these changes
Nov 20, 2023
yang1318
reviewed
Nov 20, 2023
Comment on lines
+1
to
+7
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources> | ||
| <style name="AnimationDialogStyle"> | ||
| <item name="android:windowEnterAnimation">@anim/dialog_open</item> | ||
| <item name="android:windowExitAnimation">@anim/dialog_close</item> | ||
| </style> | ||
| </resources> |
| return null | ||
| } | ||
|
|
||
| private fun checkRange(node: Node, x: Float, y: Float): Boolean { |
There was a problem hiding this comment.
저는 checkRange 라는 이름에서 check가 뭔가 True, False를 반환하는 타입 같아 보이지 않는 것 같다고 느껴지는 것 같아요. Range도 살짝 아쉬운데.. isInsideNode 같은 이름은 어떤가요?
hegleB
reviewed
Nov 20, 2023
Comment on lines
5
to
7
| interface NodeClickListener { | ||
| fun onDoubleClicked(node: Node,color:Int) | ||
| } |
There was a problem hiding this comment.
불필요한 리스너가 추가 된 것 같아요!! 확인 부탁드려요
checkRange -> isInsideNode NodeClickListener 제거 -> viewModel 대체 DialogInterface 변수명 수정
yang1318
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업한 내용
텍스트에 따른 노드 크기 조절
선택 시 stroke 표시
참고자료