마인드맵 화면 구성 #67
Merged
마인드맵 화면 구성 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaehan4707
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
바텀바의 영역이 너무 모호해서 색깔 바꾸면 좋을거같아요!
There was a problem hiding this comment.
gray1 에서 gray2로 변경했습니다~!
구분이 어렵다는 피드백을 받고 backgruond color를 gray1 에서 gray2로 변경
hegleB
reviewed
Nov 20, 2023
Comment on lines
31
to
75
| <LinearLayout | ||
| android:id="@+id/ll_mindmap_bottom_bar" | ||
| android:layout_width="0dp" | ||
| android:layout_height="wrap_content" | ||
| android:background="@color/gray2" | ||
| android:orientation="horizontal" | ||
| android:paddingHorizontal="30dp" | ||
| android:paddingVertical="20dp" | ||
| app:layout_constraintBottom_toBottomOf="parent" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintStart_toStartOf="parent"> | ||
|
|
||
| <ImageButton | ||
| android:id="@+id/imgbtn_mindmap_add" | ||
| android:layout_width="25dp" | ||
| android:layout_height="25dp" | ||
| android:layout_weight="1" | ||
| android:background="@android:color/transparent" | ||
| android:src="@drawable/ic_add" /> | ||
|
|
||
| <ImageButton | ||
| android:id="@+id/imgbtn_mindmap_remove" | ||
| android:layout_width="25dp" | ||
| android:layout_height="25dp" | ||
| android:layout_weight="1" | ||
| android:background="@android:color/transparent" | ||
| android:src="@drawable/ic_remove" /> | ||
|
|
||
| <ImageButton | ||
| android:id="@+id/imgbtn_mindmap_edit" | ||
| android:layout_width="25dp" | ||
| android:layout_height="25dp" | ||
| android:layout_weight="1" | ||
| android:background="@android:color/transparent" | ||
| android:src="@drawable/ic_outlined_drawing" /> | ||
|
|
||
| <ImageButton | ||
| android:id="@+id/imgbtn_mindmap_back" | ||
| android:layout_width="25dp" | ||
| android:layout_height="25dp" | ||
| android:layout_weight="1" | ||
| android:background="@android:color/transparent" | ||
| android:src="@drawable/ic_undo" /> | ||
|
|
||
| </LinearLayout> |
There was a problem hiding this comment.
노드 선택 시 BottomBar 숨김 처리를 위해 LinearLayout을 사용하신 것 같아요. 그런데 ConstraintLayout의 Group 기능을 활용하면 visibility 관리가 더욱 용이해질 거예요. 또한, 요소들 사이의 간격을 조절할 때는 ConstraintLayout의 chainStyle을 사용해 보시는 것도 좋은 선택일 것 같습니다
hegleB
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업한 내용