♻️ Groups API Swagger Response 오류 수정

boostcampwm2023 · Feb 2, 2024 · fc1b1b9 · fc1b1b9
1 parent 95264d6
commit fc1b1b9
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 25 deletions.
diff --git a/app/backend/src/groups/groups.controller.ts b/app/backend/src/groups/groups.controller.ts
@@ -34,7 +34,6 @@ export class GroupsController {
   @ApiQuery({ name: 'access-code', description: '참가할 그룹의 승인 코드' })
   @ApiResponse({ status: 201, description: 'Successfully retrieved group information' })
   @ApiResponse({ status: 401, description: 'Unauthorized' })
-  @ApiResponse({ status: 403, description: 'Forbidden' })
   @ApiResponse({ status: 404, description: 'Group not found for the provided access code' })
   async getGroupByAccessCode(@Query('access_code') accessCode: string): Promise<Group & { membersCount: number }> {
     return this.groupsService.getGroupByAccessCode(accessCode);
@@ -101,7 +100,6 @@ export class GroupsController {
   @ApiParam({ name: 'id', description: '참가를 취소할 그룹의 Id' })
   @ApiResponse({ status: 200, description: 'Successfully leaved join' })
   @ApiResponse({ status: 401, description: 'Unauthorized' })
-  @ApiResponse({ status: 403, description: 'Forbidden' })
   @ApiResponse({ status: 404, description: 'Group with id not found' })
   async leaveGroup(@Param('id', ParseIntPipe) id: number, @GetUser() member: Member): Promise<void> {
     return this.groupsService.leaveGroup(id, member);

diff --git a/app/backend/src/groups/groups.repository.ts b/app/backend/src/groups/groups.repository.ts
@@ -83,33 +83,29 @@ export class GroupsRepository {
   }
 
   async createGroups(createGroupsDto: CreateGroupsDto, member: Member): Promise<{ group: Group; accessCode: string }> {
-    try {
-      const { title, groupTypeId } = createGroupsDto;
-
-      const group = await this.prisma.group.create({
-        data: {
-          title: title,
-          groupTypeId: groupTypeId,
-          member: {
-            connect: { id: Number(member.id) },
-          },
-        },
-      });
+    const { title, groupTypeId } = createGroupsDto;
 
-      const accessCode = uuidv4();
-      await this.prisma.groupAccessCode.create({
-        data: {
-          accessCode,
-          groupId: group.id,
+    const group = await this.prisma.group.create({
+      data: {
+        title: title,
+        groupTypeId: groupTypeId,
+        member: {
+          connect: { id: Number(member.id) },
         },
-      });
+      },
+    });
 
-      await this.joinGroup(Number(group.id), member);
+    const accessCode = uuidv4();
+    await this.prisma.groupAccessCode.create({
+      data: {
+        accessCode,
+        groupId: group.id,
+      },
+    });
 
-      return { group, accessCode };
-    } catch (error) {
-      throw new Error(`Failed to create group: ${error.message}`);
-    }
+    await this.joinGroup(Number(group.id), member);
+
+    return { group, accessCode };
   }
 
   async joinGroup(id: number, member: Member): Promise<void> {