Handle Unhandled events with global errors (#1488)

* Handle Unhandled events with global errors * rush change * fix integration test * fix event store reduce super kind * Update pnpm-lock.yaml after merge --------- Co-authored-by: Castro, Mario <[email protected]>
boostercloud · Jul 31, 2024 · c474f64 · c474f64
1 parent 9199bbb
commit c474f64
Show file tree

Hide file tree

Showing 11 changed files with 240 additions and 114 deletions.
diff --git a/...changes/@boostercloud/framework-core/unhandled_events_global_errors_2023-10-30-14-52.json b/...changes/@boostercloud/framework-core/unhandled_events_global_errors_2023-10-30-14-52.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@boostercloud/framework-core",
+      "comment": "Handle non-found events with global error handler",
+      "type": "minor"
+    }
+  ],
+  "packageName": "@boostercloud/framework-core"
+}
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/packages/framework-core/src/booster-global-error-dispatcher.ts b/packages/framework-core/src/booster-global-error-dispatcher.ts
@@ -9,6 +9,7 @@ import {
   ProjectionGlobalError,
   SnapshotPersistHandlerGlobalError,
   QueryHandlerGlobalError,
+  EventGlobalError,
 } from '@boostercloud/framework-types'
 import { getLogger } from '@boostercloud/framework-common-helpers'
 
@@ -48,14 +49,14 @@ export class BoosterGlobalErrorDispatcher {
         case SnapshotPersistHandlerGlobalError:
           newError = await this.handleSnapshotPersistError(error)
           break
+        case EventGlobalError:
+          newError = await this.handleEventError(error)
+          break
       }
 
       newError = await this.handleGenericError(newError)
     } catch (e) {
-      logger.error(
-        `Unhandled error inside the global error handler. When handling error ${error.originalError}, another error occurred`,
-        e
-      )
+      logger.error(`Unhandled error inside the global error handler. When handling error ${error.originalError}`, e)
       return e
     }
     if (newError) return newError
@@ -112,6 +113,12 @@ export class BoosterGlobalErrorDispatcher {
     return this.errorHandler.onSnapshotPersistError(currentError.originalError, currentError.snapshot)
   }
 
+  private async handleEventError(error: GlobalErrorContainer): Promise<Error | undefined> {
+    if (!this.errorHandler || !this.errorHandler.onEventError) throw error.originalError
+    const currentError = error as EventGlobalError
+    return await this.errorHandler.onEventError(currentError.originalError, currentError.eventEnvelope)
+  }
+
   private async handleGenericError(error: Error | undefined): Promise<Error | undefined> {
     if (!error) return undefined
     if (!this.errorHandler || !this.errorHandler.onError) throw error