Add NonExposed parameter decorator #1395
Conversation
PR Summary
|
packages/framework-integration-tests/src/commands/change-cart-item.ts
Outdated
Show resolved
Hide resolved
gonzalojaubert
force-pushed
the
ignore_decorator
branch
from
21997ab
to
29c97d0
Compare
|
/integration sha=eb84eb9 |
|
⌛ Integration tests are running... Check their status here 👈 |
gonzalojaubert
changed the title
|
/integration sha=b079792 |
|
⌛ Integration tests are running... Check their status here 👈 |
|
❌ Oh no! Integration tests have failed |
|
✅ Integration tests have finished successfully! |
| fields: Array<PropertyMetadata>, | ||
| excludeProps?: Array<string> | ||
| ): Array<PropertyMetadata> { | ||
| return excludeProps ? fields.filter((field: PropertyMetadata) => !excludeProps.includes(field.name)) : [...fields] |
There was a problem hiding this comment.
Nitpick: We can just return the same array instead of making a copy.
| return excludeProps ? fields.filter((field: PropertyMetadata) => !excludeProps.includes(field.name)) : [...fields] | |
| return excludeProps ? fields.filter((field: PropertyMetadata) => !excludeProps.includes(field.name)) : fields |
| return methodName | ||
| } | ||
| const argumentNames = getFunctionArguments(target) | ||
| return argumentNames[parameterIndex!] |
There was a problem hiding this comment.
I think using ! will throw if the value is undefined. I know that, supposedly, if methodName is undefined, then parameterIndex must not... but we can't be sure. My suggestion is to add a explicit throw here with a message that tells exactly that "we could not get field name information in {this class}, {this method name}, etc.".
That way, we would know instantly what the error is about, instead of needing to debug something like undefined can be used to index or, worse, fail silently and having an array of "non exposed fields" all filled with undefined 😂
|
/integration sha=bdf4b0a |
|
⌛ Integration tests are running... Check their status here 👈 |
|
✅ Integration tests have finished successfully! |
Description
Add a decorator to remove a parameter from GraphQL Schema
Changes
Checks