Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store Azure events in batch #1436

Merged
merged 10 commits into from
Apr 12, 2024
Merged

Store Azure events in batch #1436

merged 10 commits into from
Apr 12, 2024

Conversation

gonzalojaubert
Copy link
Contributor

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Sep 26, 2023

PR Summary

  • New Event File Addition
    A new file named azure_batch_events_2023-09-26-08-49.json has been added to the directory common/changes/@boostercloud/framework-core.

  • Dependency Update
    The pnpm-lock.yaml file in the common/config/rush directory has been updated. This has resulted in the update of the @boostercloud/eslint-config and @boostercloud/framework-types dependencies from version 1.18.1 to version 1.19.0.

  • Addition of Command File
    A new command file change-multiple-cart-items-with-ids.ts has been introduced in the packages/framework-integration-tests/src/commands directory.

  • Function Reorganization in Azure Provider
    The function storeEvents has been relocated from the index.ts file in the packages/framework-provider-azure/src directory and the events-adapter.ts file in the packages/framework-provider-azure/src/library directory.

  • New Adapter File Addition
    A new adapter file events-store-adapter.ts was introduced in the packages/framework-provider-azure/src/library directory.

  • Test File Update
    Changes were implemented to the events-adapter.test.ts file in the packages/framework-provider-azure/test/library directory. This involved the removal of the test for the storeEvents method.

  • Addition of Test File
    A new test file events-store-adapter.test.ts was added in the framework-provider-azure/test/library directory. This includes tests for new adapter module EventsStoreAdapter.

  • Additional Improvements in Testing
    Several improvements were made within testing including the addition of necessary imports, creation of mock instances, addition of helper functions, setting up test environments, and modifying linting scenarios.

@gonzalogarciajaubert
Copy link
Collaborator

/integration sha=c5c242187c05ae9167c8a363c6b7c8f03afcc713

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

✅ Integration tests have finished successfully!

@gonzalogarciajaubert gonzalogarciajaubert marked this pull request as draft October 26, 2023 13:51
@boostercloud boostercloud deleted a comment Nov 27, 2023
@gonzalogarciajaubert
Copy link
Collaborator

/integration sha=297c117

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

✅ Integration tests have finished successfully!

Castro, Mario added 2 commits March 26, 2024 17:14
Merge remote-tracking branch 'origin/main' into azure_batch_events
27fc132 
# Conflicts:
#	common/config/rush/pnpm-lock.yaml
#	packages/framework-provider-azure/src/index.ts
#	packages/framework-provider-azure/src/library/events-adapter.ts
#	packages/framework-provider-azure/test/library/events-adapter.test.ts
Update pnpm-lock.yaml after merge
c143ec0
@MarcAstr0
Copy link
Collaborator

/integration sha=c143ec07420149d011c27037c8d0ab174af2b63b

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

✅ Integration tests have finished successfully!

@MarcAstr0 MarcAstr0 marked this pull request as ready for review March 27, 2024 12:50
@MarcAstr0
Copy link
Collaborator

/integration sha=f9793a60

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

✅ Integration tests have finished successfully!

alvaroloes
alvaroloes approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@alvaroloes alvaroloes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comment about interpolation before merging

packages/framework-provider-azure/src/library/events-store-adapter.ts Outdated Show resolved Hide resolved
@MarcAstr0
Copy link
Collaborator

/integration sha=46642c8

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@MarcAstr0
Copy link
Collaborator

/integration sha=46642c8

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

✅ Integration tests have finished successfully!

@MarcAstr0 MarcAstr0 merged commit 0c58d89 into boostercloud:main Apr 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcAstr0 MarcAstr0 MarcAstr0 left review comments

@alvaroloes alvaroloes alvaroloes approved these changes

@javiertoledo javiertoledo Awaiting requested review from javiertoledo

@charlietfe charlietfe Awaiting requested review from charlietfe

@NickSeagull NickSeagull Awaiting requested review from NickSeagull

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gonzalojaubert @gonzalogarciajaubert @MarcAstr0 @alvaroloes