Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read Models projections by ReadModel query #1469

Merged
merged 19 commits into from
Jul 30, 2024
Merged

Read Models projections by ReadModel query #1469

merged 19 commits into from
Jul 30, 2024

Conversation

gonzalojaubert
Copy link
Contributor

@gonzalojaubert gonzalojaubert commented Oct 16, 2023 •
edited
Loading

TODO refactor

@gonzalojaubert gonzalojaubert marked this pull request as draft October 16, 2023 08:32
@ghost
Copy link

ghost commented Oct 16, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@gonzalogarciajaubert
Copy link
Collaborator

/integration sha=8b61944

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@gonzalogarciajaubert
Copy link
Collaborator

/integration sha=f4dbdab

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

✅ Integration tests have finished successfully!

@gonzalogarciajaubert
Copy link
Collaborator

/integration sha=c0d2976

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

✅ Integration tests have finished successfully!

@gonzalojaubert gonzalojaubert changed the title WIP - Read Models projections by ReadModel query Read Models projections by ReadModel query Nov 27, 2023
Castro, Mario added 2 commits April 17, 2024 16:00
Merge remote-tracking branch 'origin/main' into read_models_projectio…
6d9b3ca 
…ns_by_readmodel_query

# Conflicts:
#	common/config/rush/pnpm-lock.yaml
#	packages/framework-core/src/booster-event-dispatcher.ts
#	packages/framework-core/test/booster-event-dispatcher.test.ts
#	packages/framework-types/src/config.ts
Update pnpm-lock.yaml after merge
7662e4a
@MarcAstr0
Copy link
Collaborator

/integration sha=7662e4adde9c4fc2fbabc04177a9891c6ab7ee2a

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

✅ Integration tests have finished successfully!

@MarcAstr0 MarcAstr0 marked this pull request as ready for review April 19, 2024 15:18
Castro, Mario added 2 commits May 31, 2024 10:59
Merge remote-tracking branch 'origin/main' into read_models_projectio…
36f6734 
…ns_by_readmodel_query

# Conflicts:
#	common/config/rush/pnpm-lock.yaml
#	packages/framework-core/src/booster-read-models-reader.ts
#	packages/framework-provider-azure/src/helpers/query-helper.ts
Update pnpm-lock after merge
f4f963e
@davidverdu
Copy link
Collaborator

davidverdu commented Jul 29, 2024 •
edited
Loading

In a first look addressing the tests and documentation, I have commented some lines of the codes pointing out issues about naming of functions. Maybe I'm being a bit nitpicky, but Booster is opinionated and for example, naming a function update inside a ReadModel is misleading (ReadModels implement Query operations and not update/insert operations as in Commands). We can see good examples in the official documentation:

Tomorrow I'll add the reviews on the rest of the code

@MarcAstr0
Copy link
Collaborator

MarcAstr0 commented Jul 29, 2024 •
edited
Loading

@davidverdu your suggestions related to method names have been applied in commit 393fade 😉 👍

@davidverdu
Copy link
Collaborator

/integration sha=393fade

1 similar comment
@davidverdu
Copy link
Collaborator

/integration sha=393fade

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

✅ Integration tests have finished successfully!

davidverdu
davidverdu reviewed Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@davidverdu davidverdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a great feature. I have finished my review and added some comments mostly on the file packages/framework-core/src/services/read-model-store.ts .
Please let me know when you address them to approve the PR

@MarcAstr0
Copy link
Collaborator

/integration sha=a8c41f62c132e58176f9d976945804dfe3fc4cd4

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@MarcAstr0
Copy link
Collaborator

@davidverdu your comments about access modifiers and some method names in the ReadModelStore class have been addressed in commit 1786d58.

davidverdu
davidverdu approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@davidverdu davidverdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for applying the suggestions

@MarcAstr0 MarcAstr0 merged commit 2abba63 into boostercloud:main Jul 30, 2024
6 checks passed
@github-actions GitHub Actions
Copy link
Contributor

✅ Integration tests have finished successfully!

This was referenced Sep 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcAstr0 MarcAstr0 MarcAstr0 left review comments

@davidverdu davidverdu davidverdu approved these changes

@javiertoledo javiertoledo Awaiting requested review from javiertoledo

@charlietfe charlietfe Awaiting requested review from charlietfe

@alvaroloes alvaroloes Awaiting requested review from alvaroloes

@NickSeagull NickSeagull Awaiting requested review from NickSeagull

Assignees

@MarcAstr0 MarcAstr0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gonzalojaubert @gonzalogarciajaubert @MarcAstr0 @davidverdu