Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring styles over from boostbook; makes styling consistent across doc types #58

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

cdw9
Copy link
Collaborator

@cdw9 cdw9 commented Dec 7, 2024

boostorg/website-v2#1484

These changes will allow the docs to maintain their styling after boostbookv2.css is removed

@cdw9 cdw9 requested review from julioest and rbbeeston December 7, 2024 01:54
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://58.boostlook.prtest2.cppalliance.org/tools/boostlook/doc/html/index.html

@cdw9
Copy link
Collaborator Author

cdw9 commented Dec 9, 2024

I see a couple things that needs to be adjusted in the preview, so there will be some more changes coming

@julioest julioest removed the request for review from rbbeeston December 9, 2024 17:03
@julioest
Copy link
Collaborator

julioest commented Dec 10, 2024

  1. Let's add this rule to remove margin bottom for nested dl tags:
image
.boostlook dl.toc dd dl dl {
  margin-bottom: 0;
}
  1. Also, let's use the direct child combinator to keep extra padding in check for
    elements:
.boostlook dl.toc > dd {...}
  1. The home icon in boostbook libs should match antora's

Copy link
Collaborator

@julioest julioest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks great! Added some comments for this commit and also others I missed previously.

boostlook.css Show resolved Hide resolved
boostlook.css Outdated Show resolved Hide resolved
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://58.boostlook.prtest2.cppalliance.org/tools/boostlook/doc/html/index.html

@cdw9 cdw9 requested a review from rbbeeston December 17, 2024 23:06
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://58.boostlook.prtest2.cppalliance.org/tools/boostlook/doc/html/index.html

Copy link
Member

@rbbeeston rbbeeston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdw9 cdw9 merged commit 8c8b17b into boostorg:develop Dec 19, 2024
@cdw9 cdw9 deleted the 1484_boostbook branch December 19, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants