Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve axis regular precision #387

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

ryanelandt
Copy link

This PR refactors regular axis to address the issues described in #336 by incorporating some of the ideas from #386. This PR adds a unit that verifies exact indexing for various cases.

The output of ./benchmark_axis_index before the refactor:

Benchmark                         Time             CPU   Iterations
-------------------------------------------------------------------
regular<uniform>               1.31 ns         1.31 ns    538240574
regular<normal>                2.00 ns         2.00 ns    351784388
circular<uniform>              1.62 ns         1.62 ns    432490637
circular<normal>               1.62 ns         1.62 ns    424151491

The output of ./benchmark_axis_index after the refactor:

Benchmark                         Time             CPU   Iterations
-------------------------------------------------------------------
regular<uniform>               1.13 ns         1.13 ns    578725526
regular<normal>                1.71 ns         1.71 ns    399524265
circular<uniform>              1.51 ns         1.51 ns    471027721
circular<normal>               1.49 ns         1.49 ns    459937000

@ryanelandt ryanelandt marked this pull request as ready for review June 15, 2023 23:41
@ryanelandt ryanelandt mentioned this pull request Jun 16, 2023
@ryanelandt
Copy link
Author

This PR does not change the public API, but it does change private class members that are not user accessible. Modifying private class members has implications for serialization. Is this type of PR problematic in regards to Boost API stability?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant