Couple of Null check corrections #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ya1gaurav
commented
Oct 14, 2015
ya1gaurav
commented
- m_to_python is checked against Null at line 70, but not checked at 89.
- !! is same as without using this.
1. m_to_python is checked against Null at line 70, but not checked at 89. 2. !! is same as without using this.
Applied patch to free node when node->next is Null but node is Non-Null.
if condition modified to use else.
|
Please review updated patches. Thanks. |
src/converter/registry.cpp
Outdated
| delete node; | ||
| delete node; | ||
| } | ||
| else if( node ) |
There was a problem hiding this comment.
You are checking if node is not null two times instead of one. And the delete operator is a no-op when the pointer is null, this whole thing can be simply written as:
if (node != 0)
delete_node(node->next);
delete node;
There was a problem hiding this comment.
I agree delete NULL is safe.
delete handles NULL pointer, so there is no harm in removing extra NULL checks.
stefanseefeld
force-pushed
the
develop
branch
2 times, most recently
from
8ccdcff
to
3ace4a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.