refactor: query_rule consistent interpretation #865

alandefreitas · 2024-10-02T14:54:06Z

query_rule broke a grammar parse invariant by using different interpretations of the string depending on whether the reason for termination was the end of a string or a continuation with an invalid character.

fix #864

src/rfc/detail/query_part_rule.hpp

cppalliance-bot · 2024-10-02T14:59:49Z

Antora version: an automated preview of the documentation is available at https://865.urlantora.prtest2.cppalliance.org/site/index.html

codecov · 2024-10-02T15:18:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.19%. Comparing base (78ed463) to head (8038474).
Report is 6 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #865      +/-   ##
===========================================
- Coverage    99.21%   99.19%   -0.03%     
===========================================
  Files          157      157              
  Lines         8421     8415       -6     
===========================================
- Hits          8355     8347       -8     
- Misses          66       68       +2

Files with missing lines	Coverage Δ
include/boost/url/grammar/impl/variant_rule.hpp	`100.00% <ø> (ø)`
src/rfc/absolute_uri_rule.cpp	`96.42% <100.00%> (-3.58%)`	⬇️
src/rfc/detail/query_part_rule.hpp	`100.00% <100.00%> (ø)`
src/rfc/origin_form_rule.cpp	`94.73% <100.00%> (-0.27%)`	⬇️
src/rfc/query_rule.cpp	`100.00% <100.00%> (ø)`
src/rfc/relative_ref_rule.cpp	`95.65% <100.00%> (-0.35%)`	⬇️
src/rfc/uri_rule.cpp	`96.96% <100.00%> (-3.04%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78ed463...8038474. Read the comment docs.

cppalliance-bot · 2024-10-02T15:24:26Z

GCOVR code coverage report https://865.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://865.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff https://865.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot · 2024-10-02T17:09:50Z

Antora version: an automated preview of the documentation is available at https://865.urlantora.prtest2.cppalliance.org/site/index.html

cppalliance-bot · 2024-10-02T17:28:37Z

Antora version: an automated preview of the documentation is available at https://865.urlantora.prtest2.cppalliance.org/site/index.html

cppalliance-bot · 2024-10-02T17:31:51Z

GCOVR code coverage report https://865.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://865.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff https://865.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot · 2024-10-02T17:48:55Z

GCOVR code coverage report https://865.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://865.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff https://865.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot · 2024-10-02T18:48:38Z

Antora version: an automated preview of the documentation is available at https://865.urlantora.prtest2.cppalliance.org/site/index.html

cppalliance-bot · 2024-10-02T19:07:57Z

GCOVR code coverage report https://865.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://865.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff https://865.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot · 2024-10-02T23:48:37Z

Antora version: an automated preview of the documentation is available at https://865.urlantora.prtest2.cppalliance.org/site/index.html

cppalliance-bot · 2024-10-03T00:14:35Z

GCOVR code coverage report https://865.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://865.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff https://865.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot · 2024-10-03T14:29:50Z

Antora version: an automated preview of the documentation is available at https://865.urlantora.prtest2.cppalliance.org/site/index.html

cppalliance-bot · 2024-10-03T14:48:51Z

GCOVR code coverage report https://865.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://865.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff https://865.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

test/unit/params_ref.cpp

query_rule broke a grammar parse invariant by using different interpretations of the string depending on whether the reason for termination was the end of a string or a continuation with an invalid character. fix boostorg#864

cppalliance-bot · 2024-10-03T19:14:45Z

Antora version: an automated preview of the documentation is available at https://865.urlantora.prtest2.cppalliance.org/site/index.html

cppalliance-bot · 2024-10-03T19:18:33Z

Antora version: an automated preview of the documentation is available at https://865.urlantora.prtest2.cppalliance.org/site/index.html

fix boostorg#857

cppalliance-bot · 2024-10-03T19:28:37Z

Antora version: an automated preview of the documentation is available at https://865.urlantora.prtest2.cppalliance.org/site/index.html

cppalliance-bot · 2024-10-03T19:40:10Z

GCOVR code coverage report https://865.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://865.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff https://865.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot · 2024-10-03T20:02:54Z

GCOVR code coverage report https://865.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://865.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff https://865.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

alandefreitas changed the title ~~refactor: query_rule consistent nparam~~ refactor: query_rule consistent interpretation Oct 2, 2024

vinniefalco reviewed Oct 2, 2024

View reviewed changes

src/rfc/detail/query_part_rule.hpp Outdated Show resolved Hide resolved

alandefreitas force-pushed the issue-864 branch from 91ff10e to 1ea464a Compare October 2, 2024 17:02

alandefreitas force-pushed the issue-864 branch from 1ea464a to 0966a43 Compare October 2, 2024 17:26

alandefreitas force-pushed the issue-864 branch from 0966a43 to e732c4c Compare October 2, 2024 18:45

vinniefalco reviewed Oct 3, 2024

View reviewed changes

test/unit/params_ref.cpp Outdated Show resolved Hide resolved

alandefreitas added 2 commits October 3, 2024 16:07

refactor: query_rule consistent interpretation

a4180a2

query_rule broke a grammar parse invariant by using different interpretations of the string depending on whether the reason for termination was the end of a string or a continuation with an invalid character. fix boostorg#864

docs(params): exemplify param edge cases

1ea5f7b

alandefreitas force-pushed the issue-864 branch from 78a9d68 to 1eb80b8 Compare October 3, 2024 19:08

alandefreitas added 4 commits October 3, 2024 16:25

docs: replicate main playbook parameters

821e452

refactor: no deprecated variant2 alias from API

370451b

fix boostorg#857

ci: BoundsSan workflow

a0be7ec

test: cmake tests return integers

8038474

alandefreitas force-pushed the issue-864 branch from e0fbeaf to 8038474 Compare October 3, 2024 19:26

alandefreitas merged commit b6688d9 into boostorg:develop Oct 4, 2024
45 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: query_rule consistent interpretation #865

refactor: query_rule consistent interpretation #865

alandefreitas commented Oct 2, 2024

cppalliance-bot commented Oct 2, 2024

codecov bot commented Oct 2, 2024 •

edited

Loading

cppalliance-bot commented Oct 2, 2024

cppalliance-bot commented Oct 2, 2024

cppalliance-bot commented Oct 2, 2024

cppalliance-bot commented Oct 2, 2024

cppalliance-bot commented Oct 2, 2024

cppalliance-bot commented Oct 2, 2024

cppalliance-bot commented Oct 2, 2024

cppalliance-bot commented Oct 2, 2024

cppalliance-bot commented Oct 3, 2024

cppalliance-bot commented Oct 3, 2024

cppalliance-bot commented Oct 3, 2024

cppalliance-bot commented Oct 3, 2024

cppalliance-bot commented Oct 3, 2024

cppalliance-bot commented Oct 3, 2024

cppalliance-bot commented Oct 3, 2024

cppalliance-bot commented Oct 3, 2024

refactor: query_rule consistent interpretation #865

refactor: query_rule consistent interpretation #865

Conversation

alandefreitas commented Oct 2, 2024

cppalliance-bot commented Oct 2, 2024

codecov bot commented Oct 2, 2024 • edited Loading

Codecov Report

cppalliance-bot commented Oct 2, 2024

cppalliance-bot commented Oct 2, 2024

cppalliance-bot commented Oct 2, 2024

cppalliance-bot commented Oct 2, 2024

cppalliance-bot commented Oct 2, 2024

cppalliance-bot commented Oct 2, 2024

cppalliance-bot commented Oct 2, 2024

cppalliance-bot commented Oct 2, 2024

cppalliance-bot commented Oct 3, 2024

cppalliance-bot commented Oct 3, 2024

cppalliance-bot commented Oct 3, 2024

cppalliance-bot commented Oct 3, 2024

cppalliance-bot commented Oct 3, 2024

cppalliance-bot commented Oct 3, 2024

cppalliance-bot commented Oct 3, 2024

cppalliance-bot commented Oct 3, 2024

codecov bot commented Oct 2, 2024 •

edited

Loading