Fixes incorrect value validation for step attribute

README.md

@@ -35,9 +35,9 @@ Bootbox **3.3.0** is the *last* release to support Bootstrap 2.2.x.
 
 Much more dependency information can be found [on the Bootbox website](http://bootboxjs.com/getting-started.html#bootbox-dependencies).
 
-## 5.3.2 (Latest Release)
+## 5.3.3 (Latest Release)
 
-- Adds Georgian (ka) locale.
+- Fixes incorrect value validation for the `step` option when setting `inputType` to `number` for a prompt.
 
 For a full list of releases and changes please see [the changelog](https://github.com/makeusabrew/bootbox/blob/master/CHANGELOG.md).
 

bootbox.all.js

@@ -1,6 +1,6 @@
 /*! @preserve
  * bootbox.js
- * version: 5.3.2
+ * version: 5.3.3
  * author: Nick Payne <[email protected]>
  * license: MIT
  * http://bootboxjs.com/
@@ -880,7 +880,7 @@
         // @see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/date#Setting_maximum_and_minimum_dates
         if (options.inputType !== 'date') {
           if (options.step) {
-            if (options.step === 'any' || (!isNaN(options.step) && parseInt(options.step) > 0)) {
+            if (options.step === 'any' || (!isNaN(options.step) && parseFloat(options.step) > 0)) {
               input.attr('step', options.step);
             }
             else {
@@ -1346,10 +1346,12 @@
     }
     else {
       if (min !== undefined && isNaN(min)) {
+        minValid = false;
         throw new Error('"min" must be a valid number. See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attr-min for more information.');
       }
 
       if (max !== undefined && isNaN(max)) {
+        maxValid = false;
         throw new Error('"max" must be a valid number. See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attr-max for more information.');
       }
     }
@@ -1374,15 +1376,6 @@
     return /(\d{4})-(\d{2})-(\d{2})/.test(value);
   }
 
-
-  //  Register the default locale
-  exports.addLocale('en', {
-    OK: 'OK',
-    CANCEL: 'Cancel',
-    CONFIRM: 'OK'
-  });
-
-
   //  The Bootbox object
   return exports;
 }));

bootbox.js

@@ -1,6 +1,6 @@
 /*! @preserve
  * bootbox.js
- * version: 5.3.2
+ * version: 5.3.3
  * author: Nick Payne <[email protected]>
  * license: MIT
  * http://bootboxjs.com/
@@ -679,7 +679,7 @@
         // @see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/date#Setting_maximum_and_minimum_dates
         if (options.inputType !== 'date') {
           if (options.step) {
-            if (options.step === 'any' || (!isNaN(options.step) && parseInt(options.step) > 0)) {
+            if (options.step === 'any' || (!isNaN(options.step) && parseFloat(options.step) > 0)) {
               input.attr('step', options.step);
             }
             else {
@@ -1145,10 +1145,12 @@
     }
     else {
       if (min !== undefined && isNaN(min)) {
+        minValid = false;
         throw new Error('"min" must be a valid number. See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attr-min for more information.');
       }
 
       if (max !== undefined && isNaN(max)) {
+        maxValid = false;
         throw new Error('"max" must be a valid number. See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attr-max for more information.');
       }
     }

bootbox.locales.js

@@ -1,6 +1,6 @@
 /*! @preserve
  * bootbox.locales.js
- * version: 5.3.2
+ * version: 5.3.3
  * author: Nick Payne <[email protected]>
  * license: MIT
  * http://bootboxjs.com/

header.txt

@@ -1,5 +1,5 @@
 /**
- * bootbox.js 5.3.2
+ * bootbox.js 5.3.3
  *
  * http://bootboxjs.com/license.txt
  */

package.json

@@ -1,6 +1,6 @@
 {
   "name": "bootbox",
-  "version": "5.3.2",
+  "version": "5.3.3",
   "description": "Wrappers for JavaScript alert(), confirm(), prompt(), and other flexible dialogs using the Bootstrap framework",
   "directories": {
     "test": "tests"