Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a new consensus round if we get stuck #3086

Open
hewison-chris opened this issue Feb 22, 2022 · 0 comments
Open

Start a new consensus round if we get stuck #3086

hewison-chris opened this issue Feb 22, 2022 · 0 comments
Assignees

Comments

@hewison-chris
Copy link
Contributor

hewison-chris commented Feb 22, 2022

For example as suggested here if a pending block takes too long to get a majority of signatures:

Next step IMO is to put a timeout on how long a pending block can exist and if we reach it, start a new consensus round. so our assumption `block_height == slot_idx` won't hold anymore.

_Originally posted by @omerfirmak in https://github.com/bosagora/agora/issues/3039#issuecomment-1046482920_

But perhaps this could also be used once we get behind block schedule and are not making progress during nomination phases.

@hewison-chris hewison-chris changed the title Start a new consensus round if timeout on pending block takes too long Start a new consensus round if a pending block takes too long to get a majority of signatures Feb 22, 2022
@hewison-chris hewison-chris changed the title Start a new consensus round if a pending block takes too long to get a majority of signatures Start a new consensus round if we get stuck Feb 22, 2022
@hewison-chris hewison-chris added this to the 6. Stabilization milestone Feb 22, 2022
@hewison-chris hewison-chris self-assigned this Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@hewison-chris and others