Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidatingDriver #16

Merged
merged 1 commit into from
Aug 4, 2024
Merged

ValidatingDriver #16

merged 1 commit into from
Aug 4, 2024

Conversation

prdoyle
Copy link
Collaborator

@prdoyle prdoyle commented Aug 3, 2024

A new driver layer automatically inserted on the top of the driver stack to enforce validity rules that were previously being enforced by LocalDriver. The effect is to cause the enforcement to occur at submission time (when a submit method is called) instead of application time (when the change is incorporated into the local in-memory state).

Made slightly awkward by the fact that some tests like to get bosk.driver() and downcast it; this won't work anymore because driver() returns the validating layer now. Added another method called getDriver but this needs more work.

@prdoyle prdoyle merged commit 94d5e7d into boskworks:develop Aug 4, 2024
1 check passed
@prdoyle prdoyle deleted the driver-validation branch August 4, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant