Remove suspend modifier from getCapabilitiesFor

boswelja · Apr 22, 2021 · ba8da02 · ba8da02
1 parent 7947855
commit ba8da02
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/core/src/main/kotlin/com/boswelja/watchconnection/core/PlatformConnectionHandler.kt b/core/src/main/kotlin/com/boswelja/watchconnection/core/PlatformConnectionHandler.kt
@@ -28,7 +28,7 @@ interface PlatformConnectionHandler {
      * @param watchId See [Watch.platformId].
      * @return A [Flow] of capability strings declared by the watch.
      */
-    suspend fun getCapabilitiesFor(watchId: String): Flow<String>
+    fun getCapabilitiesFor(watchId: String): Flow<String>
 
     /**
      * Send a message to a watch with the given ID. Note that a successful response doesn't

diff --git a/core/src/main/kotlin/com/boswelja/watchconnection/core/WatchConnectionClient.kt b/core/src/main/kotlin/com/boswelja/watchconnection/core/WatchConnectionClient.kt
@@ -51,7 +51,7 @@ class WatchConnectionClient(
      * @param watch See [Watch].
      * @return A [Flow] of capability strings declared by the watch.
      */
-    suspend fun getCapabilitiesFor(watch: Watch): Flow<String>? {
+    fun getCapabilitiesFor(watch: Watch): Flow<String>? {
         return connectionHandlers[watch.platform]?.getCapabilitiesFor(watch.platformId)
     }
 

diff --git a/tizen/src/main/kotlin/com/boswelja/watchconnection/tizen/TizenConnectionHandler.kt b/tizen/src/main/kotlin/com/boswelja/watchconnection/tizen/TizenConnectionHandler.kt
@@ -120,7 +120,7 @@ class TizenConnectionHandler internal constructor(
     override fun watchesWithApp(): Flow<Watch> = allWatches()
 
     @ExperimentalCoroutinesApi
-    override suspend fun getCapabilitiesFor(watchId: String): Flow<String> {
+    override fun getCapabilitiesFor(watchId: String): Flow<String> {
         var flow = capabilityMap[watchId]
         if (flow == null) {
             // Flow doesn't already exist, create a new one
@@ -132,7 +132,9 @@ class TizenConnectionHandler internal constructor(
         }
 
         // Request capability stream
-        sendMessage(watchId, CAPABILITY_MESSAGE)
+        coroutineScope.launch(Dispatchers.IO + capabilityJob) {
+            sendMessage(watchId, CAPABILITY_MESSAGE)
+        }
 
         return flow.mapNotNull { it }
     }

diff --git a/wearos/src/main/kotlin/com/boswelja/watchconnection/wearos/WearOSConnectionHandler.kt b/wearos/src/main/kotlin/com/boswelja/watchconnection/wearos/WearOSConnectionHandler.kt
@@ -66,7 +66,7 @@ class WearOSConnectionHandler internal constructor(
             }
     }
 
-    override suspend fun getCapabilitiesFor(watchId: String): Flow<String> = flow {
+    override fun getCapabilitiesFor(watchId: String): Flow<String> = flow {
         // Get all capabilities
         val capabilities = capabilityClient
             .getAllCapabilities(CapabilityClient.FILTER_REACHABLE).await()