Merge pull request #26 from boswelja/messagereceiver-context

Pass context through MessageReceiver.kt
boswelja · Apr 26, 2021 · d5f7727 · d5f7727
2 parents 5d8bbb8 + 0a63b7d
commit d5f7727
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 16 deletions.
diff --git a/core/src/main/kotlin/com/boswelja/watchconnection/core/MessageReceiver.kt b/core/src/main/kotlin/com/boswelja/watchconnection/core/MessageReceiver.kt
@@ -23,6 +23,7 @@ abstract class MessageReceiver : BroadcastReceiver() {
      * @param data The data included with the message, or null if there was no data.
      */
     abstract suspend fun onMessageReceived(
+        context: Context,
         sourceWatchId: UUID,
         message: String,
         data: ByteArray?
@@ -32,19 +33,21 @@ abstract class MessageReceiver : BroadcastReceiver() {
         // Don't handle intent if it's not ACTION_MESSAGE_RECEIVED
         if (intent?.action != Messages.ACTION_MESSAGE_RECEIVED) return
 
-        // Going async
-        val pendingResult = goAsync()
-        coroutineScope.launch {
-            // Collect data from intent
-            val watchId = UUID.fromString(intent.getStringExtra(EXTRA_WATCH_ID))
-            val message = intent.getStringExtra(EXTRA_MESSAGE)!!
-            val data = intent.getByteArrayExtra(EXTRA_DATA)
-
-            // Pass it on to user code
-            onMessageReceived(watchId, message, data)
-
-            // Let the BroadcastReceiver know we're done
-            pendingResult.finish()
+        context?.let {
+            // Going async
+            val pendingResult = goAsync()
+            coroutineScope.launch {
+                // Collect data from intent
+                val watchId = UUID.fromString(intent.getStringExtra(EXTRA_WATCH_ID))
+                val message = intent.getStringExtra(EXTRA_MESSAGE)!!
+                val data = intent.getByteArrayExtra(EXTRA_DATA)
+
+                // Pass it on to user code
+                onMessageReceived(context, watchId, message, data)
+
+                // Let the BroadcastReceiver know we're done
+                pendingResult.finish()
+            }
         }
     }
 

diff --git a/test/src/test/kotlin/com/boswelja/watchconnection/core/ConcreteMessageReceiver.kt b/test/src/test/kotlin/com/boswelja/watchconnection/core/ConcreteMessageReceiver.kt
@@ -1,10 +1,12 @@
 package com.boswelja.watchconnection.core
 
+import android.content.Context
 import java.util.UUID
 
 class ConcreteMessageReceiver : MessageReceiver() {
 
     override suspend fun onMessageReceived(
+        context: Context,
         sourceWatchId: UUID,
         message: String,
         data: ByteArray?

diff --git a/test/src/test/kotlin/com/boswelja/watchconnection/core/MessageReceiverTest.kt b/test/src/test/kotlin/com/boswelja/watchconnection/core/MessageReceiverTest.kt
@@ -42,7 +42,7 @@ class MessageReceiverTest {
         val intent = Intent("action")
         messageReceiver.onReceive(context, intent)
         verify(inverse = true) { messageReceiver.goAsync() }
-        coVerify(inverse = true) { messageReceiver.onMessageReceived(any(), any(), any()) }
+        coVerify(inverse = true) { messageReceiver.onMessageReceived(any(), any(), any(), any()) }
     }
 
     @Test
@@ -57,7 +57,7 @@ class MessageReceiverTest {
             messageReceiver.onReceive(context, intent)
         }
 
-        coVerify { messageReceiver.onMessageReceived(id, message, null) }
+        coVerify { messageReceiver.onMessageReceived(context, id, message, null) }
     }
 
     @Test
@@ -74,6 +74,6 @@ class MessageReceiverTest {
             messageReceiver.onReceive(context, intent)
         }
 
-        coVerify { messageReceiver.onMessageReceived(id, message, data) }
+        coVerify { messageReceiver.onMessageReceived(context, id, message, data) }
     }
 }