Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check env config for ca bundle when verify is True #2340

Closed
wants to merge 1 commit into from
Closed

check env config for ca bundle when verify is True #2340

wants to merge 1 commit into from

Conversation

koelemay
Copy link

@koelemay koelemay commented Apr 8, 2021

Closes #2339

@stephanbertl stephanbertl mentioned this pull request Nov 10, 2023
Closed
@RyanFitzSimmonsAK
Copy link
Contributor

Hi @koelemay, thanks for this pull request and for your patience. We're going to be closing this pull request, as it is actually a potentially breaking change. Changing the behavior for True introduces the possibility of getting back new, unexpected values if something else in the environment is using requests, which is breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check for CA Bundle when True is specified for verify
2 participants
@koelemay @RyanFitzSimmonsAK