-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Changelog and update release-version to 2.1.0 #26
Conversation
## OS Changes | ||
* Update kernels: 5.10.218-208, 5.10.219, 5.15.160-104, and 6.1.94 ([#13], [#17]) | ||
* Include kmod-6.1-neuron package in core kit ([#21]) | ||
* Enable host containers and in-place updates to be optional ([#23]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add a line for your PR here:
* Enable host containers and in-place updates to be optional ([#23]) | |
* Enable host containers and in-place updates to be optional ([#23]) | |
* Provide SSM agent as a system service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it okay to put two lines in different categories for a single PR?
CHANGELOG.md
Outdated
* Move dockershim link to relative path ([#18]) | ||
|
||
### ECS | ||
* Amazon-ssm-agent: Add dynamically-linked agent binaries ([#22]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Amazon-ssm-agent: Add dynamically-linked agent binaries ([#22]) | |
* Depend on Amazon SSM plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline, remove this line in favor of the one to OS category
Force push: Recategorizing SSM agent change to OS rather than ECS |
CHANGELOG.md
Outdated
# v2.1.0 (2024-07-08) | ||
|
||
## OS Changes | ||
* Update kernels: 5.10.218-208, 5.10.219, 5.15.160-104, and 6.1.94 ([#13], [#17]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should only include the resulting version, we can skip intermediates that never "made it" like 5.10.218
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, have removed 5.10.218-208
CHANGELOG.md
Outdated
|
||
## OS Changes | ||
* Update kernels: 5.10.218-208, 5.10.219, 5.15.160-104, and 6.1.94 ([#13], [#17]) | ||
* Include kmod-6.1-neuron package in core kit ([#21]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Include is a useful word when describing variants, for the core kit, I personally prefer "Add" vs "Include".
* Include kmod-6.1-neuron package in core kit ([#21]) | |
* Add kmod-6.1-neuron package to core kit ([#21]) |
@@ -0,0 +1,19 @@ | |||
# v2.1.0 (2024-07-08) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Ideally we would have one commit for the CHANGELOG entry and one for version bumps.
Signed-off-by: Kush Upadhyay <[email protected]>
Signed-off-by: Kush Upadhyay <[email protected]>
Force push revises wording in |
Issue number: N/A
Closes # N/A
Description of changes:
CHANGELOG
: Creating this new file with changes for the upcoming v2.1.0 releaseTwoliter.toml
: Bumpingrelease-version
from2.0.0
to2.1.0
+ related update toTwoliter.lock
Testing done:
make ARCH=aarch64 && make ARCH=x86_64
succeedsTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.