updog: Don't source migrations from a downloaded root image #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updog downloads the root image before writing it to disk so that it can be mounted and searched for existing migrations, in an effort to reduce network traffic. However this has two problems in the current approach: - It doesn't solve the issue of trust for the "other" side when it boots and finds these migrations. - If run from a container with smaller cgroup limits (eg. dogswatch) it can invoke the OOM killer! Be more conservative with memory and remove this approach. Future patches will introduce a more trusted and less memory-hungry solution. Signed-off-by: Samuel Mendoza-Jonas <[email protected]>
|
Still need to properly test this as my build host is being slow 🐢 |
bcressey
approved these changes
Oct 16, 2019
|
Tested updating normally with no other change in behaviour. |
jahkeup
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #414
Description of changes:
Updog downloads the root image before writing it to disk so that it can
be mounted and searched for existing migrations, in an effort to reduce
network traffic. However this has two problems in the current approach:
and finds these migrations.
it can invoke the OOM killer!
Be more conservative with memory and remove this approach. Future
patches will introduce a more trusted and less memory-hungry solution.
Signed-off-by: Samuel Mendoza-Jonas [email protected]
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.