Allow template defaults in case of failed generator #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404.
If we can't determine max-pods because we fail to talk to IMDS or fail to read/parse the max-pods file, we want to have a fallback (the Kubernetes default) rather than leaving Kubernetes entirely broken.
This includes a few related commits that allow us to do it cleanly, and to handle other similar cases that come up.
default
template helper that allows easier specification of defaults in templates, rather than big conditionals with repetition of the setting.Testing done:
Determining max-pods via IMDS still works:
If I remove the setting and remove the max-pods file...
...then we use the template default; we can see thar-be-settings using it:
The default shows up:
sundog/pluto work again if we restore things: