Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use some dependencies in samples #2900

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

EliasOfWaffle
Copy link
Contributor

@EliasOfWaffle EliasOfWaffle commented May 13, 2023

Install mono, gecko and faudio for default in game environment. Install mono and gecko for default in application environment .

Description

Can be provide best support for games and applications for default.
In Wine Gecko and Mono is used for default in wine

Fixes #(issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.

  • Test A
  • Test B

Install mono, gecko and faudio for default in game environment.
Install mono and gecko for default in application environment .
@TheEvilSkeleton TheEvilSkeleton added this to the 52.0 milestone Jun 8, 2023
@github-actions
Copy link
Contributor

Pylint result on modfied files:
************* Module bottles.backend.models.samples
bottles/backend/models/samples.py:1:0: R0903: Too few public methods (0/2) (too-few-public-methods)

@koplo199
Copy link
Contributor

Note: the mypy check failing was due to a bug that existed upstream at the time of the PR, not because of the change made here.
Rebasing/Updating the branch will get rid of the wrongly attributed failed mark.

@koplo199
Copy link
Contributor

@orowith2os Any chance of this PR being merged soon™?

@fab-sonarqube
Copy link

fab-sonarqube bot commented Aug 29, 2023

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@orowith2os orowith2os merged commit c2c3237 into bottlesdevs:main Aug 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants