Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct icon in dependency-entry.blp for downloads #2948

Closed
wants to merge 3 commits into from

Conversation

CosmicFusion
Copy link

@CosmicFusion CosmicFusion commented Jul 2, 2023

Description

I know bottles is design around Adwaita and Adwaita only.

but save icons are universally agreed to be floppy disks and adwaita is the one in the wrong here to make save a download icon

So bottles should use a download icon instead such as the one in this PR and the icon would be universally correct in all DEs and icon themes

Will not causing any harm

Fixes #2949

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.

  • Look at it using the adwaita icon theme.
  • Look at it using Papirus and vimix.

I know bottles is design around Adwaita and Adwaita only.

but save icons are universally agreed to be floppy disks
and adwaita is the one in the wrong here to make save a download icon

So bottles should use a download icon instead such as the one in this PR and the icon would be universally correct in all DEs and icon themes

Will not causing any harm
@orowith2os
Copy link
Contributor

Your wording here makes it seem as if libadwaita and Bottles are hostile to other desktops. Try and think of the reasoning behind things, and the full context - just saying "adwaita is the one in the wrong" helps no one.

Please make an issue with the libadwaita folks over in adwaita-icon-theme to see if they'll change document-save to a floppy disk, and if not, their reasoning for why.

@CosmicFusion
Copy link
Author

Your wording here makes it seem as if libadwaita and Bottles >are hostile to other desktops.

That's was not my intention

Just seeing "Stop theming our apps" url stamped on the readme

Made me think that validation is only done against adwaita

And I was not sure about the overall stance on this

Try and think of the reasoning behind things, and the full context - just saying "adwaita is the one in the wrong" helps no one.

True...

Please make an issue with the libadwaita folks over in adwaita-icon-theme to see if they'll change document-save to a floppy disk, and if not, their reasoning for why.

Will do my friend

@TheEvilSkeleton TheEvilSkeleton marked this pull request as draft July 19, 2023 21:47
@TheEvilSkeleton
Copy link
Contributor

Drafting this as it's blocked by upstream. When you file the issue, please link here so we can track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: Bottles is using save icon for downloads instead of download icon
4 participants