Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Use active instead of state property #3006

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

TheEvilSkeleton
Copy link
Contributor

Description

state should only be used when the switch is in a working state.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.

  • Locally

@github-actions
Copy link
Contributor

Pylint result on modfied files:
************* Module bottles.frontend.windows.vmtouch
bottles/frontend/windows/vmtouch.py:66:0: C0305: Trailing newlines (trailing-newlines)
bottles/frontend/windows/vmtouch.py:23:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/windows/vmtouch.py:25:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/windows/vmtouch.py:20:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/windows/vmtouch.py:54:8: C0206: Consider iterating with .items() (consider-using-dict-items)
bottles/frontend/windows/vmtouch.py:54:23: C0201: Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)
bottles/frontend/windows/vmtouch.py:24:0: R0903: Too few public methods (0/2) (too-few-public-methods)
************* Module bottles.frontend.windows.vkbasalt
bottles/frontend/windows/vkbasalt.py:251:0: C0305: Trailing newlines (trailing-newlines)
bottles/frontend/windows/vkbasalt.py:56:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/windows/vkbasalt.py:58:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/windows/vkbasalt.py:29:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/windows/vkbasalt.py:30:0: E0401: Unable to import 'vkbasalt.lib' (import-error)
bottles/frontend/windows/vkbasalt.py:36:0: R0903: Too few public methods (0/2) (too-few-public-methods)
bottles/frontend/windows/vkbasalt.py:100:12: W0621: Redefining name 'VkBasaltSettings' from outer scope (line 36) (redefined-outer-name)
bottles/frontend/windows/vkbasalt.py:100:12: C0103: Variable name "VkBasaltSettings" doesn't conform to snake_case naming style (invalid-name)
bottles/frontend/windows/vkbasalt.py:115:19: C0121: Comparison 'conf[0] != None' should be 'conf[0] is not None' (singleton-comparison)
bottles/frontend/windows/vkbasalt.py:118:15: C0121: Comparison 'VkBasaltSettings.smaa_edge_detection != None' should be 'VkBasaltSettings.smaa_edge_detection is not None' (singleton-comparison)
bottles/frontend/windows/vkbasalt.py:149:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
bottles/frontend/windows/vkbasalt.py:144:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/windows/vkbasalt.py:176:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/windows/vkbasalt.py:180:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/windows/vkbasalt.py:186:11: C0121: Comparison 'self.check_effects_states() == False' should be 'self.check_effects_states() is False' if checking for the singleton value False, or 'not self.check_effects_states()' if testing for falsiness (singleton-comparison)
bottles/frontend/windows/vkbasalt.py:184:24: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/windows/vkbasalt.py:190:43: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/windows/vkbasalt.py:211:8: R1703: The if statement can be replaced with 'return bool(test)' (simplifiable-if-statement)
bottles/frontend/windows/vkbasalt.py:211:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
bottles/frontend/windows/vkbasalt.py:217:29: C0103: Argument name "VkBasaltSettings" doesn't conform to snake_case naming style (invalid-name)
bottles/frontend/windows/vkbasalt.py:217:29: W0621: Redefining name 'VkBasaltSettings' from outer scope (line 36) (redefined-outer-name)
************* Module bottles.frontend.windows.gamescope
bottles/frontend/windows/gamescope.py:110:0: C0305: Trailing newlines (trailing-newlines)
bottles/frontend/windows/gamescope.py:21:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/windows/gamescope.py:23:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/windows/gamescope.py:18:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/windows/gamescope.py:56:29: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/windows/gamescope.py:98:8: C0206: Consider iterating with .items() (consider-using-dict-items)
bottles/frontend/windows/gamescope.py:98:23: C0201: Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)
bottles/frontend/windows/gamescope.py:22:0: R0903: Too few public methods (0/2) (too-few-public-methods)

@TheEvilSkeleton TheEvilSkeleton merged commit 05f779a into main Jul 30, 2023
5 checks passed
@TheEvilSkeleton TheEvilSkeleton deleted the active-properties branch July 30, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant