Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Add arguments and custom executables to URI #3016

Closed
wants to merge 1 commit into from

Conversation

tancop
Copy link

@tancop tancop commented Aug 4, 2023

Description

Add a new protocol to the URI handler (bottles:runExe) that lets the user run any executable, not just previously added programs, and the option to pass arguments to both run and runExe. This is necessary to let other flatpaks like Heroic Games Launcher open apps in Bottles.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@tancop tancop closed this Aug 4, 2023
@tancop tancop changed the title Add runExe and arguments in uri Frontend: Add arguments and custom executables to URI Aug 4, 2023
@tancop tancop reopened this Aug 4, 2023
@orowith2os
Copy link
Contributor

Does this not already work? Apparently Bottles shows as an executable handler, not sure why this is necessary.

image

@Mikenux
Copy link

Mikenux commented Aug 20, 2023

@orowith2os:

@tpotancok opened an issue at flatpak: flatpak/xdg-desktop-portal#1071.

I think it's related to this PR, given the descriptions. I've made a few interpretations of what is wanted, but your guesses are welcome (and whether my interpretations of how Bottles work are correct or not).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants