Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create shortcuts in subdirectory #3019

Closed
wants to merge 1 commit into from

Conversation

j8r
Copy link

@j8r j8r commented Aug 6, 2023

Description

Fixes #2264 by creating and giving the rights to create shortcuts into a specific applications directory.
We no longer need to run flatpak override com.usebottles.bottles --user --filesystem=xdg-data/applications, the permission is given by default.
There is no security application since Bottles only has the right to create and remove shortcuts in its specific ~/.local/share/applications/bottles directory.
~/.local/share/applications still need to exist.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.

  • build flatpak run org.flatpak.Builder --user --install --force-clean --ccache build-dir com.usebottles.bottles.yml
  • run flatpak run --env=DEBUG_MODE=true com.usebottles.bottles
  • create a bottle then a shortcut
  • remove the shortcut and/or bottle

Fixes bottlesdevs#2264 by creating and giving the rights to create shortcuts into a specific applications directory.
@j8r
Copy link
Author

j8r commented Aug 6, 2023

No idea why the linter fails, not related to the changes I made.

@orowith2os
Copy link
Contributor

We should use the DynamicLauncher portal, not write to the paths directly. It's been discussed in the past. Permissions like this are best documented and added by the end user for the time being.

Wrt. the DynamicLauncher portal, PRs welcome.

@orowith2os orowith2os closed this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Bottle's can't create a desktop entry if the XDG applications directory does not exist.
2 participants