Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "all files" to the "add shortcuts" file picker #3204

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

DekosAnjo
Copy link
Contributor

@DekosAnjo DekosAnjo commented Dec 20, 2023

Description

Fix for #3199 that adds a "all files" option to the "add shortcuts" file picker as a workaround for a gnome bug

Fixes #3199

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.

  • Open the "add shortcuts" file picker

Fix for bottlesdevs#3199 that adds a "all files" option to the "add shortcuts" file picker as a workaround for a gnome bug
Copy link

fab-sonarqube bot commented Dec 20, 2023

@pablogila
Copy link

Thanks!

@koplo199 koplo199 mentioned this pull request Dec 23, 2023
Copy link
Contributor

Pylint result on modfied files:
************* Module bottles.frontend.views.bottle_details
bottles/frontend/views/bottle_details.py:50:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/views/bottle_details.py:52:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/views/bottle_details.py:116:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/views/bottle_details.py:118:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/views/bottle_details.py:119:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/views/bottle_details.py:348:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/views/bottle_details.py:350:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/views/bottle_details.py:505:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/views/bottle_details.py:24:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/views/bottle_details.py:154:12: W0105: String statement has no effect (pointless-string-statement)
bottles/frontend/views/bottle_details.py:173:4: R0913: Too many arguments (6/5) (too-many-arguments)
bottles/frontend/views/bottle_details.py:186:25: W0613: Unused argument 'a' (unused-argument)
bottles/frontend/views/bottle_details.py:186:28: W0613: Unused argument 'b' (unused-argument)
bottles/frontend/views/bottle_details.py:173:22: W0613: Unused argument 'drop_target' (unused-argument)
bottles/frontend/views/bottle_details.py:173:56: W0613: Unused argument 'x' (unused-argument)
bottles/frontend/views/bottle_details.py:173:59: W0613: Unused argument 'y' (unused-argument)
bottles/frontend/views/bottle_details.py:173:62: W0613: Unused argument 'user_data' (unused-argument)
bottles/frontend/views/bottle_details.py:195:23: W0613: Unused argument 'drop_target' (unused-argument)
bottles/frontend/views/bottle_details.py:195:36: W0613: Unused argument 'x' (unused-argument)
bottles/frontend/views/bottle_details.py:195:39: W0613: Unused argument 'y' (unused-argument)
bottles/frontend/views/bottle_details.py:199:23: W0613: Unused argument 'drop_target' (unused-argument)
bottles/frontend/views/bottle_details.py:239:18: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_details.py:343:31: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_details.py:354:30: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_details.py:365:41: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_details.py:396:29: W0613: Unused argument 'a' (unused-argument)
bottles/frontend/views/bottle_details.py:396:32: W0613: Unused argument 'b' (unused-argument)
bottles/frontend/views/bottle_details.py:373:29: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_details.py:373:37: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/views/bottle_details.py:442:27: W0613: Unused argument 'error' (unused-argument)
bottles/frontend/views/bottle_details.py:426:23: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_details.py:474:26: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_details.py:490:31: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_details.py:520:37: W0613: Unused argument 'response_id' (unused-argument)
bottles/frontend/views/bottle_details.py:538:4: W0105: String statement has no effect (pointless-string-statement)
bottles/frontend/views/bottle_details.py:543:26: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_details.py:547:24: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_details.py:551:25: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_details.py:554:27: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_details.py:558:22: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_details.py:563:18: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_details.py:567:30: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_details.py:571:31: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_details.py:575:30: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_details.py:579:26: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_details.py:585:18: W0613: Unused argument 'result' (unused-argument)
bottles/frontend/views/bottle_details.py:585:31: W0613: Unused argument 'error' (unused-argument)
bottles/frontend/views/bottle_details.py:611:17: R1719: The if expression can be replaced with 'not test' (simplifiable-if-expression)

@mirkobrombin mirkobrombin merged commit 1038a08 into bottlesdevs:main Dec 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Supported files doesn't show up in the selection menu when adding a program
4 participants