Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generic.py to repair the SyntaxWarning #3286

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

TDYQ-Liu
Copy link
Contributor

@TDYQ-Liu TDYQ-Liu commented Feb 21, 2024

Description

Please include a summary of the change and which issue is fixed (if available).
Please also include relevant motivation and context.

Fixes #(issue)

when start bottles from CLI
I get /usr/share/bottles/bottles/backend/utils/generic.py:95: SyntaxWarning: invalid escape sequence '\d'

reference the python doc

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.

  • Test A
  • Test B

when start bottles from CLI
I get `generic.py:95: SyntaxWarning: invalid escape sequence '\d'`

reference the [python doc](https://docs.python.org/3/reference/lexical_analysis.html#string-and-bytes-literals)
Copy link

fab-sonarqube bot commented Feb 21, 2024

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

fab-sonarqube bot commented Mar 25, 2024

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

Pylint result on modfied files:
************* Module bottles.backend.utils.generic
bottles/backend/utils/generic.py:88:4: W0702: No exception type(s) specified (bare-except)
bottles/backend/utils/generic.py:80:8: C0415: Import outside toplevel (ctypes) (import-outside-toplevel)

@mirkobrombin mirkobrombin merged commit 7b735cc into bottlesdevs:main Mar 25, 2024
6 checks passed
@TDYQ-Liu TDYQ-Liu deleted the patch-1 branch March 25, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants