Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update POTFILES and translation template #3318

Closed

Conversation

ryonakano
Copy link
Contributor

Description

The translation template is outdated and missing some strings, which means translators can't complete their work. So, I updated the POTFILES and translation template.

I would like the maintainers of Bottles to enable the Update PO files to match POT (msgmerge) addon on Hosted Weblate, because updating .po files too in this PR would cause conflicts in #3313. Enabling this addon makes Weblate update .po from .pot automatically.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Run git grep -l -w _\( -- bottles > po/POTFILES
  • Manually edit POTFILES because the previous command removes comments and paths under data/ dir
  • Run meson setup builddir --prefix=/usr -Ddevel=true
  • Run ninja -C builddir
  • Run ninja -C builddir bottles-pot

Copy link

fab-sonarqube bot commented Mar 23, 2024

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

Pylint result on modfied files:

Copy link
Contributor

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

I will send a reminder to Mirkob about the add-on (we have been discussing about it for a while).

@ryonakano
Copy link
Contributor Author

ryonakano commented Apr 4, 2024

Converting to draft since I'd like to re-update the pot after #3333 get merged.

@ryonakano ryonakano marked this pull request as draft April 4, 2024 14:16
@ryonakano ryonakano closed this Aug 26, 2024
@ryonakano ryonakano deleted the update-translation-template branch August 26, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants