fix: "bottles:run/" uri processing #3444
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It all started when I created a shortcut for Steam. After launching it, the bottle selection menu appeared and nothing else happened.
As tests have shown, the try block was always executed successfully (the return occurred immediately after the bottle selection GUI was created). Processing of
bottles:run/
never occurred.Bottles/bottles/frontend/main.py
Lines 203 to 208 in 7e60ede
In addition, the URI was then passed as is as the "-e" argument to
bottles-cli
, which led to a crash.Bottles/bottles/frontend/windows/bottlepicker.py
Lines 79 to 80 in 7e60ede
After this small patch, URI processing is now done first. In addition, the bottle selection GUI no longer appears (I can’t understand why the selection is needed if the bottle is ALREADY specified in the URI)
Fixes #3443
(At least it looks a lot like it)
Type of change
How Has This Been Tested?
xdg-open bottles:run/<bottle>/<program>
without patch (not working)xdg-open bottles:run/<bottle>/<program>
with patch (working)