Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support create sign request calls with sign template IDs #834

Merged
merged 2 commits into from
Aug 11, 2023
Merged

feat: Support create sign request calls with sign template IDs #834

merged 2 commits into from
Aug 11, 2023

Conversation

dtrodger
Copy link
Contributor

@dtrodger dtrodger commented Aug 1, 2023

No description provided.

@dtrodger dtrodger changed the title Support create sign request calls with sign template IDs feat: Support create sign request calls with sign template IDs Aug 1, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5831971824

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 93.528%
Totals Coverage Status
Change from base Build 5725071206: 0.003%
Covered Lines: 3454
Relevant Lines: 3693
💛 - Coveralls

congminh1254
congminh1254 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@congminh1254 congminh1254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, moved the param to the end to avoid conflict with some existing uses.
And also update the tests.

@congminh1254 congminh1254 merged commit 4f11d75 into box:main Aug 11, 2023
9 of 11 checks passed
@congminh1254 congminh1254 mentioned this pull request Sep 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congminh1254 congminh1254 congminh1254 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dtrodger @coveralls @congminh1254