fix(content-sidebar): remove dependency on isSignRemoveInterstitialEnabled #3734
+46
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-in-a-box
changed the title
greg-in-a-box
changed the title
JChan106
previously approved these changes
Nov 4, 2024
GonchuB
reviewed
Nov 5, 2024
| const { getByTestId } = renderComponent({}, features); | ||
| fireEvent.click(getByTestId('sign-button')); | ||
| fireEvent.click(getByTestId('sign-request-signature-button')); | ||
| const wrapper = renderComponent({}, features); |
There was a problem hiding this comment.
nit: is it possible to use screen instead of calling methods on the return value of the render function?
https://kentcdodds.com/blog/common-mistakes-with-react-testing-library#not-using-screen
There was a problem hiding this comment.
agree, let's update it 👍
GonchuB
previously approved these changes
Nov 5, 2024
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
from
aea92d0
to
1020007
Compare
JChan106
previously approved these changes
Nov 5, 2024
greg-in-a-box
requested changes
Nov 5, 2024
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
from
1020007
to
bdba5eb
Compare
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
from
bdba5eb
to
3b5d387
Compare
greg-in-a-box
requested changes
Nov 6, 2024
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
from
3b5d387
to
a982541
Compare
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
from
a982541
to
f4855fe
Compare
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
from
f4855fe
to
8fd8f2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The isSignRemoveInterstitialEnabled feature flag was recently cleaned up on the application side, causing a production defect due to a dependency in this components. This commit removes the dependency in BUIE components to align with the application.