Fix QuartzJobsDeleteCommandTest to pass on Mysql #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it failed because the job name in Quartz was too long. This is a simple fix that rename the class in order to make name shorter and fit within the Mysql constraint. An alertnative fix is to shorten the name, and there is some code to do that at QuartzPollableTaskScheduler#getShortClassName(). It is not currently used, not sure if it was unfinished development or if it has some issue. Anyway put a note here, but going with the quick fix since it is good enough for the current need
garionpin
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it failed because the job name in Quartz was too long. This is a simple fix that rename the class in order to make name shorter and fit within the Mysql constraint.
An alertnative fix is to shorten the name, and there is some code to do that at QuartzPollableTaskScheduler#getShortClassName(). It is not currently used, not sure if it was unfinished development or if it has some issue. Anyway put a note here, but going with the quick fix since it is good enough for the current need