Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture otel metrics for OAuth errors and add logging to stderr #3437

Merged
merged 27 commits into from
Dec 25, 2024
Merged

Capture otel metrics for OAuth errors and add logging to stderr #3437

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
6478846
Add new counters
niwsa Dec 16, 2024
3142507
Increment error counter for authorize
niwsa Dec 16, 2024
14faf6d
Log authorize errors to `stderr`
niwsa Dec 16, 2024
78f5edc
Minor formatting
niwsa Dec 16, 2024
05c1658
Merge branch 'main' into add-oauth-tracing
niwsa Dec 17, 2024
e2623e4
Add metrics and error logging for token handler
niwsa Dec 17, 2024
db75a64
New counter for idp response path
niwsa Dec 18, 2024
19dee14
Capture metrics for remaining handlers
niwsa Dec 18, 2024
0665e08
Removing logging from npm, let service do it
niwsa Dec 18, 2024
cd7045b
Log service error in oidc/saml response paths
niwsa Dec 18, 2024
ee35690
Cleanup
niwsa Dec 18, 2024
33c7722
Simplify metric name
niwsa Dec 18, 2024
510130f
Use renamed metric and set protocol attribute
niwsa Dec 18, 2024
efcc20b
Merge branch 'main' into add-oauth-tracing
niwsa Dec 18, 2024
16f1c4b
Sync lock file
niwsa Dec 18, 2024
de89de7
Tweak error message
niwsa Dec 19, 2024
3de9fd3
Add protocol and login_type tags to authorize and response metrics
niwsa Dec 19, 2024
d4a99b6
Log error for oAuth redirect error responses
niwsa Dec 19, 2024
d1dd6a8
Add protocol and login_type to error metrics inside token/userinfo ha…
niwsa Dec 19, 2024
348a5b7
Merge branch 'main' into add-oauth-tracing
niwsa Dec 19, 2024
2676774
Set attributes earlier in the flow if possible
niwsa Dec 20, 2024
7b6f59c
Set protocol early in the flow
niwsa Dec 21, 2024
d17cff8
Revert lock file changes
niwsa Dec 21, 2024
e0ab925
Revert lock file changes
niwsa Dec 21, 2024
b91dd3a
Merge branch 'main' into add-oauth-tracing
deepakprabhakara Dec 23, 2024
758ca0d
print err instead of just message
deepakprabhakara Dec 23, 2024
454d52a
error -> err in catch blocks for consistency
deepakprabhakara Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading