pkp#9946 Do not remove numbers from the beginning of each citation:

* pkp#9946 * https://forum.pkp.sfu.ca/t/if-a-reference-list-item-starts-with-a-numeral-it-is-removed-3-1-2-4-and-3-3-0-15
bozana · May 31, 2024 · 7233357 · 7233357
1 parent 5ab5d86
commit 7233357
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/classes/citation/CitationListTokenizerFilter.inc.php b/classes/citation/CitationListTokenizerFilter.inc.php
@@ -47,11 +47,8 @@ function &process(&$input) {
 		} else {
 			$citations = explode("\n", $input);
 		}
-		// 4) Remove numbers from the beginning of each citation.
-		foreach($citations as $index => $citation) {
-			$citations[$index] = PKPString::regexp_replace('/^\s*[\[#]?[0-9]+[.)\]]?\s*/', '', $citation);
-		}
-
+		// 4) Remove whitespace from the beginning and the end of each citation.
+		$citations = array_map('trim', $citations);
 		return $citations;
 	}
 }

diff --git a/tests/classes/citation/CitationListTokenizerFilterTest.php b/tests/classes/citation/CitationListTokenizerFilterTest.php
@@ -25,10 +25,10 @@ public function testCitationListTokenizerFilter() {
 		$tokenizer = new CitationListTokenizerFilter();
 		$rawCitationList = "\t1. citation1\n\n2 citation2\r\n 3) citation3\n[4]citation4";
 		$expectedResult = array(
-			'citation1',
-			'citation2',
-			'citation3',
-			'citation4'
+			'1. citation1',
+			'2 citation2',
+			'3) citation3',
+			'[4]citation4'
 		);
 		self::assertEquals($expectedResult, $tokenizer->process($rawCitationList));