Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/docker update #948

Merged
merged 9 commits into from
Oct 27, 2024
Merged

Feature/docker update #948

merged 9 commits into from
Oct 27, 2024

Conversation

grasdk
Copy link
Contributor

@grasdk grasdk commented Oct 25, 2024

Resolves issue 777

Also adds linting checks to dockerfiles and resolves linting errors. Linting errors about versioning packages are ignored (DL3008 and DL3018)

@bpatrik
Copy link
Owner

bpatrik commented Oct 27, 2024

Thanks. I did not test how removing the Volume tags would change the behavior, but I will just take your word that it will just keep working.

@bpatrik bpatrik merged commit 42400fa into bpatrik:master Oct 27, 2024
5 of 8 checks passed
@jdavidpeter
Copy link

To me it seems that the change of --update-cache to --no-cache in the Alpine Docker file broke the build.
I can't build an Alpine Docker image on Raspberry Pi 5 using Ubuntu unless I revert that change.
@grasdk Would you kindly opine if this was an oversight?

@grasdk
Copy link
Contributor Author

grasdk commented Jan 4, 2025

To me it seems that the change of --update-cache to --no-cache in the Alpine Docker file broke the build. I can't build an Alpine Docker image on Raspberry Pi 5 using Ubuntu unless I revert that change. @grasdk Would you kindly opine if this was an oversight?

@jdavidpeter That seems weird, but if that is your experience, I can't contest it. What command did you build it with?

As far as I know @bpatrik uses buildx, which can build for multiple architectures including for ARM64 which I believe is the rPi5 architecture. Can you install and run the edge image for ARM64 from docker hub on your rpi5?

docker pull bpatrik/pigallery2:edge-alpine

If you're building locally on your rPi5, try and see if you can mimic the command you will see here, when you expand "Build docker" and look at line 164 (marked in blue):
image
My best guess would be docker buildx build --file docker/alpine/Dockerfile.build --platform linux/arm64, but I've never tried it with pigallery2.

@bpatrik
Copy link
Owner

bpatrik commented Jan 5, 2025

As far as I can tell buildx in github action works: https://hub.docker.com/r/bpatrik/pigallery2/tags/ last build was 2 months ago on all platforms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using VOLUME in the Dockerfile
3 participants