Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebDAV sync feature added to KeePassDroid #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Rupan
Copy link

@Rupan Rupan commented Dec 7, 2011

Brian - I know that this is something that you've put off doing, probably because it is a lot of work... Trust me, it was :) I am aware that there is some concern w.r.t requesting network permissions on install, but consider that the desktop applications already have such access. I am also aware that this isn't a perfect implementation, but I decided to not let perfection get in the way of a pretty awesome functionality.

I plan to use this sync feature within my company's IT department to share password lists, and also to keep my own personal list of secrets on an Apache server that I control. So I'm hoping that this functionality makes it into mainline.

@bpellin
Copy link
Owner

bpellin commented Dec 7, 2011

Mike,

I'm currently working on getting write support for .kdbx in. Once, I
get a release out for that (no promises when), I'll take a look at
this.

I am a little nervous about adding the internet permission to the app.
I have been toying around with the idea of creating an API within the
app for loading and saving databases. That way users could chose to
install additional plugin apps that have the internet permission.
Then, webdav could be a plugin, and I could also create another plugin
that integrates with dropbox more tightly. I'll have to decide if it's
worth the effort to add in all of the extra abstraction though.

-Brian

On Wed, Dec 7, 2011 at 12:22 AM, Michael Mohr
[email protected]
wrote:

Brian - I know that this is something that you've put off doing, probably because it is a lot of work...  Trust me, it was :)  I am aware that there is some concern w.r.t requesting network permissions on install, but consider that the desktop applications already have such access.  I am also aware that this isn't a perfect implementation, but I decided to not let perfection get in the way of a pretty awesome functionality.

I plan to use this sync feature within my company's IT department to share password lists, and also to keep my own personal list of secrets on an Apache server that I control.  So I'm hoping that this functionality makes it into mainline.

You can merge this Pull Request by running:

 git pull https://github.com/Rupan/keepassdroid master

Or you can view, comment on it, or merge it online at:

 #16

-- Commit Summary --

  • add webdav sync feature

-- File Changes --

M AndroidManifest.xml (4)
A res/drawable/btn_black.xml (37)
A res/drawable/btn_blue.xml (37)
A res/drawable/btn_brown.xml (37)
A res/drawable/btn_green.xml (37)
A res/drawable/btn_purple.xml (37)
A res/drawable/btn_red.xml (37)
A res/drawable/btn_yellow.xml (37)
M res/layout/password.xml (38)
A res/layout/webdav_prefs.xml (120)
M res/values/styles.xml (25)
M src/com/keepassdroid/PasswordActivity.java (80)
M src/com/keepassdroid/fileselect/FileDbHelper.java (43)
A src/net/temerity/davsync/DAVException.java (32)
A src/net/temerity/davsync/DAVNetwork.java (336)
A src/net/temerity/davsync/DAVProfile.java (38)
A src/net/temerity/davsync/HttpPropFind.java (45)
A src/net/temerity/davsync/PropFindHandler.java (54)
A src/net/temerity/davsync/davsync.java (207)

-- Patch Links --

 https://github.com/bpellin/keepassdroid/pull/16.patch
 https://github.com/bpellin/keepassdroid/pull/16.diff


Reply to this email directly or view it on GitHub:
#16

Conflicts:
	AndroidManifest.xml
@DanielSCy
Copy link

Hi,

I just wanted to add my thoughts about this. I would avoid any application which offers to keep all my passwords and accounts and is asking for Internet access.

In order to quickly upload newer DB to cloud, I personally did a small change to KeePassDroid by adding a menu item which shares the DB file. So after I change something in the DB, I back out to the first screen (where I am choosing the DB), click the share action and then choose Dropbox from the target chooser dialog. For me this is a good enough way to keep the DB in the cloud, with minimum hassle.

@Lotzy
Copy link

Lotzy commented Dec 21, 2012

Absolutely agree with Brian and DanielSCy, avoid internet permission. KeePassDroid should follow the KeePass application philosophy which is: safely store passwords in an encrypted file. So, syncing should be external to the app, anyone being free to do whatever they want with the encrypted file, eventually using any third party cloud service for syncing purpose.

I personally use Dropbox with added security of BoxCryptor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants