Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support implicit starts #145

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Support implicit starts #145

merged 5 commits into from
Dec 18, 2023

Conversation

nikku
Copy link
Member

@nikku nikku commented Dec 15, 2023

Spawn tokens along with normal starts:

capture gFe0dU_optimized

Only when no normal starts are present these can be triggered individually:

capture AY8a2N_optimized

Closes #144

What we export is essential an ES module, not a CJS export.
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Dec 15, 2023
@nikku nikku requested a review from a team December 15, 2023 19:29
@nikku nikku changed the title Support implict starts Support implicit starts Dec 16, 2023
@nikku nikku force-pushed the 144-implicit-starts branch 2 times, most recently from 91952dd to 72a0c62 Compare December 16, 2023 11:07
Copy link

@smbea smbea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and works well, as far as I can tell

@nikku nikku merged commit f3163ee into main Dec 18, 2023
6 checks passed
@nikku nikku deleted the 144-implicit-starts branch December 18, 2023 10:52
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 18, 2023
@nikku
Copy link
Member Author

nikku commented Dec 18, 2023

Let's get it released them 🚀.

@nikku
Copy link
Member Author

nikku commented Dec 18, 2023

Released with v0.33.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit starts are not properly handled
2 participants