Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This reverts commit 3cdf61e. After updating from Uvicorn 0.28.1 to Uvicorn >=0.29.0, coverage.py reports that `inboard.gunicorn_workers.UvicornWorker.callback_notify` and the test ASGI app (`tests.test_gunicorn_workers.app`) are not being covered when they actually are covered by the tests. `callback_notify` runs after the Gunicorn server has started up, and the test ASGI app is obviously used (otherwise the tests couldn't pass). Possibly related to the unexpected change in test coverage, coverage.py is generating less coverage files with Uvicorn >=0.29.0. This could suggest that some of the subprocesses used in the tests aren't exiting cleanly or aren't being detected by coverage.py. Signal handling has changed substantially in Uvicorn >=0.29.0, but those changes haven't been tested with the workers because Uvicorn doesn't test its workers, as noted in 35d8d86. Until the changes to signal handling and test coverage are understood more clearly, Uvicorn will remain on version 0.28.1.
- Loading branch information