-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for wrong escaping in bc #12
base: master
Are you sure you want to change the base?
Conversation
Sorry the fix does not work in mixed content with other bc. and bc... |
In my fix the force of HTML entity encoding is done in code for bc now. commit https://github.com/GwenDragon/text-textile/commit/a30437f923aea5919bcdef06bce5955f7175a671 works now correctly. I hope. ;) |
I'll take a closer look; thanks for your patience and persistence. However, this is a breaking change that could affect existing uses of Textile out there. I need to take that into consideration. |
@bradchoate Thanks for reply.
How does my patch violate Textiles behaviour? As i understood the docs for textiles bc, I thought all text in
MoveableType.org: Textile 2 Syntax
That means: There is no hint in docs, that bc does skip some HTML elements or XML prolog. HTML docs states for code element:
I think it means the raw text, not interpreted as JS or HTML. Do i misinterpet this so much? Please explain. If i'm not right, pease add the ability to have a setting running bc in "escaping HTML mode". PS: I'm a Perl programming webdev and webmistress, HTML is familiar for me. ;)
Thanks. And for maintaining the Perl package, not letting it getting orphan. |
Hello,
I have made a fix and test for problems with bc (see issue #3)
Please check and add this fix.