Changes in the way remoteAddr and remoteHost are calculated and ES #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently remoteAddr and remoteHost are both just taken from the headers in the request. This does not work when the application is behind a proxy or loadbalancer. I added logic to better calculate these two values.
The idea is to cascade down from better to less correct information.
For remoteAddr:
For remoteHost:
This has worked in my testing using Apache and mod_proxy with Tomcat6 on the backend.
I also added the spanish internationalization file requested in: http://github.com/bradleybeddoes/nimble/issues/#issue/32