Removed unnecessary "en-US" CultureInfo

[Blaisor]

Removed unnecessary instantiation of "en-US" CultureInfo to allow globalization invariant mode.
See: https://aka.ms/GlobalizationInvariantMode

[bradymholt]

I read the docs in the link you provided and am still not sure what the implications of this change are. Can you elaborate on the implications and reason for this change?

[Blaisor]

Sure. Now if you enable globalization invariant mode in a .NET project, once it tries to use ExpressionParser, it throws an exception:

Only the invariant culture is supported in globalization-invariant mode. See https://aka.ms/GlobalizationInvariantMode for more information. (Parameter 'name') en-US is an invalid culture identifier.

What I did is to remove that particular CultureInfo instance which is only used in generating month names, but in this case the invariant culture could produce exact same names. But with this small change, any project can enable <InvariantGlobalization> without any issues.

[phillip-haydon]

I happen to have this exact same issue. Deploying to linux with <InvariantGlobalization>true</InvariantGlobalization> causes an exception. I thought I could override this using the options locale but line 40 causes it to throw up :(

[phillip-haydon]

As a work-around for this I had to install the locales on linux; icu for it to work. Bit of a hassle when I don't need globalization support.

[bradymholt]

Thanks!

[github-actions]

The changes in PR were just released in 2.36.0 🎉.