Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optical Flow Update and Helmholtz Hodge Decomposition Enabling #311

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

LeoNouvelle
Copy link

Hello,
Here are the changes I commited in my pull request:

Minor code updates and corrections on:

  • panel_opticalflow
  • bst_opticalflow_states
  • bst_opticalflow

Enabling Helmholtz-Hodge Decomposition:

  • panel_opticalflow (gui perspective)
  • bst_opticalflow_hhd (new function, maths)

Thanks,
Léo

hold(hEnergy, 'off');
end
end

% Uncomment following lines to display the unfilterd/original figure.
% if displayFlag
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already only executed when the displayFlag is set, why the need to uncomment this for debugging?

@martcous
Copy link
Member

martcous commented Jul 3, 2020

Thank you Leo for your update. You are only modifying files related to the optical flow so this is a pretty safe merge. Were you planning on writing a documentation for your changes? This would greatly help us test this.

Some minor comments right off the bat:

  • The GUI freezes and it takes a long time to compute after you click on a big source file and go to Plug-Ins -> [Experimental] Optical flow. Is it possible to add a progress bar to tell the user a computation is happening so they know their computer is not frozen? Refer to bst_progress.
  • Some code is commented out without explanation
  • There are some comments in French in the code ;)

Great work!
Martin

@ftadel
Copy link
Member

ftadel commented Feb 3, 2022

@LeoNouvelle
Is this PR still a work in progress?

@sbaillet
Copy link
Collaborator

sbaillet commented Feb 3, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants