Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPS-482: Navigation menu not redirecting correctly #915

Open
wants to merge 5 commits into
base: release-candidate
Choose a base branch
from

Conversation

vijetaR
Copy link
Contributor

@vijetaR vijetaR commented Oct 22, 2024

Description

This pull request includes updates to fix the navigation menu anchor links and enhance the user experience when interacting with submenu items. The most important changes are as follows:

Bug Fixes:

  • README.md: Updated the changelog to include a fix for anchor links correctly scrolling to sections/containers when submenu items with IDs are clicked.
  • readme.txt: Added a similar changelog entry to reflect the fix for anchor links in the navigation menu.

Code Optimization:

  • inc/js/frontend.js: Enhanced the _handleSinglePageMenu function to prevent the default action for anchor links and smoothly scroll to the target section if it exists.

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Checklist:

  • My code is tested
  • My code passes the PHPCS tests
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@vijetaR vijetaR requested a review from sushmak02 November 13, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant