Add aria-hidden to generic card icon and aria-required to Hosted Fields #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibooker
reviewed
Nov 14, 2023
| @@ -726,6 +726,61 @@ describe('CardView', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| test.only('sets aria-required attribute on hosted fields', () => { | |||
There was a problem hiding this comment.
Should this still say .only?
There was a problem hiding this comment.
Good catch. Fixed.
oscarleonnogales
approved these changes
Nov 14, 2023
|
Change looks good, but noticed the test isn't passing |
Yep, fixed the failing unit and publishing tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
aria-hiddenlabel to the generic card icon in the upper left corner of the cardview so that screenreaders do not read it. Also, adds thearia-requiredlabel to the input in the hosted fields so screen readers can accurately indicate it is a required field.Checklist
Authors