-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit paymentMethodRequestable event after 3DS Challenge is completed #917
Conversation
completed for 3DS flows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good first pass, but I don't think we cover all scenarios where 3DS "completes."
Why does 3DS have to be so complicated :lolsob:
Co-authored-by: Holly Richko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Jira
Holds off sending the
paymentMethodRequestable
event until afterverifyCard
has completed for 3DS flows.Addresses #805
Testing strategy:
Run the Drop-in demo in development mode and add the following query parameters to the URL in your browser:
?threeDSecure=true&authorization=<generate-a-client-token>
Then test each test card listed in our 3DS documentation to make sure everything works as expected on each flow. Open the dev console and notice that the event does not fire off until 3DS authentication is completed:
paymentMethodRequestable {paymentMethodIsSelected: true, type: 'CreditCard'}
Checklist
Authors